Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GP001: fix outdated filenames in exercises #47

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

eemilhaa
Copy link
Contributor

@eemilhaa eemilhaa commented Sep 4, 2024

Fixes #45

In addition to just replacing file extension, I also updated the filenames according to the new course directory.

Some things to consider before merging:

  • Exercise 2: all shapefile-specific explanatory text is now removed (dfc67f6), leading to a lot of rewording in the exercise in general. This should probably be checked.
  • Exercise 6: The metadata file for the population dataset Vaestotietoruudukko_2022 (in .pdf format) is missing from the data directory. External to this repo, but I'll still mention it here.
  • All in-text references to the course directory expect the structure to be Kurssihakemisto/Harjoitus_x/some.file. The current course directory structure is simply Kurssihakemisto/some.file. I left the paths untouched based on 40 gp002 change all shp to gpkg #43 (comment)

- use .gpkg instead of .shp
- remove and reword text to skip explaining shapefiles
- use .gpkg instead of .shp
- update filenames to match the course directory
@eemilhaa eemilhaa linked an issue Sep 4, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Preview changes here.

@eemilhaa eemilhaa marked this pull request as draft September 4, 2024 11:42
@eemilhaa eemilhaa added the question Further information is requested label Sep 4, 2024
@jeeemil jeeemil self-requested a review September 6, 2024 07:24
@jeeemil
Copy link
Contributor

jeeemil commented Sep 6, 2024

Elisa is in charge of this course, but since she is away, and I've been teaching this course in the spring at least once I guess I could check the Shapefile-text. Since the data is changed the only logical thing to do is to also change the text as you did. I think we could go forward with this and when Elisa returns, or if the course is up for more in-depth updates, then it could be discussed if we should have an exercise where we go through shapefiles. Then we could just grab the nice tables and stuff from this course. In any case I feel the most logical data to add in the beginning would be a geopackage so a shapefile-add could then be a completely separate topic.

I updated the course directory, so point 2 and 3 are done.

@jeeemil jeeemil marked this pull request as ready for review September 6, 2024 08:01
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Preview changes here.

@jeeemil
Copy link
Contributor

jeeemil commented Sep 6, 2024

@eemilhaa I updated a few images where the old files where present. If the changes are okay with you, this PR is ready for merge.

@eemilhaa
Copy link
Contributor Author

eemilhaa commented Sep 6, 2024

@jeeemil Looks good to me, good catch on the screenshots!

@jeeemil jeeemil merged commit dfd53d2 into main Sep 6, 2024
1 check passed
@jeeemil jeeemil deleted the 45-gp001-outdated-filenames-in-exercises branch September 6, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GP001: outdated filenames in exercises
2 participants